Skip to content

gh-116145: Update macOS installer to Tcl/Tk 8.6.14#116151

Merged
ned-deily merged 1 commit intopython:mainfrom
chrstphrchvz:tcltk8.6.14mac
Mar 12, 2024
Merged

gh-116145: Update macOS installer to Tcl/Tk 8.6.14#116151
ned-deily merged 1 commit intopython:mainfrom
chrstphrchvz:tcltk8.6.14mac

Conversation

@chrstphrchvz
Copy link
Contributor

@chrstphrchvz chrstphrchvz commented Feb 29, 2024 •
edited by bedevere-app bot
Loading

@chrstphrchvz chrstphrchvz requested a review from a team as a code owner February 29, 2024 20:56
@bedevere-app bedevere-app bot mentioned this pull request Feb 29, 2024
Closed
@ned-deily ned-deily self-assigned this Feb 29, 2024
ned-deily
ned-deily approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@ned-deily ned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR!

@ned-deily ned-deily merged commit 4fa95c6 into python:main Mar 12, 2024
@bedevere-bot
Copy link

bedevere-bot commented Mar 12, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Debian root 3.x has failed when building commit 4fa95c6.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/345/builds/7405) and take a look at the build logs.
  4. Check if the failure is related to this commit (4fa95c6) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/345/builds/7405

Failed tests:

  • test.test_concurrent_futures.test_thread_pool

Failed subtests:

  • test_extractall_none_uid - test.test_tarfile.NoneInfoExtractTests_Data.test_extractall_none_uid
  • test_sumprod_stress - test.test_math.MathTests.test_sumprod_stress
  • test_threads - test.test_io.PyBufferedReaderTest.test_threads

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_math.py", line 1441, in test_sumprod_stress
    self.assertEqual(
    ~~~~~~~~~~~~~~~~^
        run(baseline_sumprod, *args),
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        run(sumprod, *args),
        ^^^^^^^^^^^^^^^^^^^^
        args,
        ^^^^^
    )
    ^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/case.py", line 884, in assertEqual
    assertion_func = self._getAssertEqualityFunc(first, second)
                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/case.py", line 868, in _getAssertEqualityFunc
    asserter = getattr(self, asserter)
               ~~~~~~~^^^^^^^^^^^^^^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/case.py", line 690, in __call__
    return self.run(*args, **kwds)
           ~~~~~~~~^^^^^^^^^^^^^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/case.py", line 609, in run
    result.startTest(self)
    ^^^^^^^^^^^^^^^^
AttributeError: 'str' object has no attribute 'startTest'


Traceback (most recent call last):
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_tarfile.py", line 3218, in test_extractall_none_uid
    with self.extract_with_none('uid'):
        pass
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/contextlib.py", line 141, in __enter__
    return next(self.gen)
           ~~~~^^^^^^^^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_tarfile.py", line 3182, in extract_with_none
    self.check_files_present(DIR)
    ~~~~~~~~~~~~~~~~~~~~~~~~^^^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_tarfile.py", line 3168, in check_files_present
    got_paths = set(
                ~~~^
        p.relative_to(directory)
        ^^^^^^^^^^^^^^^^^^^^^^^^
        for p in pathlib.Path(directory).glob('**/*'))
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_tarfile.py", line 3169, in <genexpr>
    p.relative_to(directory)
    ~~~~~~~~~~~~~^^^^^^^^^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/pathlib/__init__.py", line 389, in relative_to
    if path == self or path in self.parents:
                       ^^^^^^^^^^^^^^^^^^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/_collections_abc.py", line 1033, in __contains__
    for v in self:
        if v is value or v == value:
            return True
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/_collections_abc.py", line 1026, in __iter__
    v = self[i]
        ~~~~^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/pathlib/__init__.py", line 58, in __getitem__
    return self._path._from_parsed_parts(self._drv, self._root,
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^
                                         self._tail[:-idx - 1])
                                         ^^^^^^^^^^^^^^^^^^^^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/pathlib/__init__.py", line 256, in _from_parsed_parts
    path_str = self._format_parsed_parts(drv, root, tail)
               ~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/pathlib/__init__.py", line 250, in _format_parsed_parts
    return drv + root + cls.pathmod.sep.join(tail)
                        ~~~~~~~~~~~~~~~~~~~~^^^^^^
TypeError: can only join an iterable


Traceback (most recent call last):
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_io.py", line 1574, in test_threads
    random.shuffle(l)
    ~~~~~~~~~~~~~~^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/random.py", line 361, in shuffle
    x[i], x[j] = x[j], x[i]
    ~^^^
TypeError: 'Random' object does not support item assignment

adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@chrstphrchvz @adorilson
pythongh-116145: Update macOS installer to Tcl/Tk 8.6.14 (pythonGH-11…
fdeb67e 
…6151)
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@chrstphrchvz @diegorusso
pythongh-116145: Update macOS installer to Tcl/Tk 8.6.14 (pythonGH-11…
5dd4b4f 
…6151)
@ned-deily ned-deily added the needs backport to 3.12 only security fixes label Jun 1, 2024
@miss-islington-app
Copy link

miss-islington-app bot commented Jun 1, 2024

Thanks @chrstphrchvz for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 1, 2024
@chrstphrchvz @miss-islington
pythongh-116145: Update macOS installer to Tcl/Tk 8.6.14 (pythonGH-11…
8629058 
…6151)

(cherry picked from commit 4fa95c6)

Co-authored-by: Christopher Chavez <chrischavez@gmx.us>
@bedevere-app
Copy link

bedevere-app bot commented Jun 1, 2024

GH-119922 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Jun 1, 2024
ned-deily pushed a commit that referenced this pull request Jun 1, 2024
@miss-islington @chrstphrchvz
[3.12] gh-116145: Update macOS installer to Tcl/Tk 8.6.14 (GH-116151) (…
46545d3 
…GH-119922)

(cherry picked from commit 4fa95c6)
Co-authored-by: Christopher Chavez <chrischavez@gmx.us>
@chrstphrchvz chrstphrchvz deleted the tcltk8.6.14mac branch November 12, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ned-deily ned-deily ned-deily approved these changes

Assignees

@ned-deily ned-deily

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chrstphrchvz @bedevere-bot @ned-deily